commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From greenman18523 <...@git.apache.org>
Subject [GitHub] commons-lang issue #335: LANG-1400: Add StringUtils.mask() function
Date Sun, 24 Jun 2018 17:14:25 GMT
Github user greenman18523 commented on the issue:

    https://github.com/apache/commons-lang/pull/335
  
    Hello @stokito, as mentioned in #332, would you consider an extra parameter, to clearly
specify the minimum number of masked characters?
    From your implementation I can see that it is enforced, but it is limited, and it is not
documented clearly either in the javadoc or by the parameter names.
    
    The extra parameter can also make the method not being implicit on the unmasking of start/end
(``// we prefer to unmask from start and mask end if str len is smaller``) and choose to equally
subtract from ``unmaskedStart`` and ``unmaskedEnd`` to enforce the minimum amount of masked
characters.
    



---

Mime
View raw message