commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ingvarc <...@git.apache.org>
Subject [GitHub] commons-lang pull request #334: Code refactoring and cleaning
Date Fri, 22 Jun 2018 05:56:17 GMT
Github user ingvarc commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/334#discussion_r197346902
  
    --- Diff: src/main/java/org/apache/commons/lang3/builder/CompareToBuilder.java ---
    @@ -600,10 +600,10 @@ public CompareToBuilder append(final boolean lhs, final boolean
rhs) {
             if (lhs == rhs) {
                 return this;
             }
    -        if (!lhs) {
    -            comparison = -1;
    -        } else {
    +        if (lhs) {
                 comparison = +1;
    --- End diff --
    
    Actually, the plus sign is redundant here. I've tried to link commits with only one type
of changes and therefore haven't removed it.


---

Mime
View raw message