From issues-return-67886-archive-asf-public=cust-asf.ponee.io@commons.apache.org Sat May 19 16:52:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E5BFC18063B for ; Sat, 19 May 2018 16:52:06 +0200 (CEST) Received: (qmail 97331 invoked by uid 500); 19 May 2018 14:52:05 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 97320 invoked by uid 99); 19 May 2018 14:52:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 May 2018 14:52:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7A9EB1802E5 for ; Sat, 19 May 2018 14:52:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id QiZskiBPVjRJ for ; Sat, 19 May 2018 14:52:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D0AA15F1E4 for ; Sat, 19 May 2018 14:52:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 61ECDE00FC for ; Sat, 19 May 2018 14:52:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 15B0A212B7 for ; Sat, 19 May 2018 14:52:00 +0000 (UTC) Date: Sat, 19 May 2018 14:52:00 +0000 (UTC) From: "Gary Gregory (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CSV-225) Parse method should avoid creating a redundant BufferedReader MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CSV-225?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated CSV-225: ----------------------------- External issue URL: https://github.com/apache/commons-csv/pull/28 External issue ID: 28 > Parse method should avoid creating a redundant BufferedReader > ------------------------------------------------------------- > > Key: CSV-225 > URL: https://issues.apache.org/jira/browse/CSV-225 > Project: Commons CSV > Issue Type: Improvement > Components: Parser > Affects Versions: 1.5 > Reporter: Anson Schwabecher > Priority: Minor > Fix For: 1.6 > > > A redundant BufferedReader is created as the inner reader of ExtendedBuff= eredReader when the CSVParser is created with: > {{CSVParser#parse(Path, Charset, CSVFormat)}} > Simply change over from {{Files#newBufferedReader to Files#newInputStream= }} > =C2=A0 > {{public static CSVParser parse(final Path path, final Charset charset, f= inal CSVFormat format) throws IOException {}} > {{=C2=A0=C2=A0=C2=A0 Assertions.notNull(path, "path");}} > {{=C2=A0=C2=A0=C2=A0 Assertions.notNull(format, "format");}} > {{=C2=A0=C2=A0=C2=A0 return parse(Files.newInputStream(path), charset, f= ormat);}} > {{}}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)