From issues-return-68079-archive-asf-public=cust-asf.ponee.io@commons.apache.org Tue May 29 16:31:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0D95C180676 for ; Tue, 29 May 2018 16:31:03 +0200 (CEST) Received: (qmail 55641 invoked by uid 500); 29 May 2018 14:31:03 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 55630 invoked by uid 99); 29 May 2018 14:31:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 May 2018 14:31:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B05FDCD056 for ; Tue, 29 May 2018 14:31:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id M2vyLuw87rjU for ; Tue, 29 May 2018 14:31:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5CFFC5F359 for ; Tue, 29 May 2018 14:31:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8D045E01C0 for ; Tue, 29 May 2018 14:31:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 48C0021094 for ; Tue, 29 May 2018 14:31:00 +0000 (UTC) Date: Tue, 29 May 2018 14:31:00 +0000 (UTC) From: "Gary Gregory (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (CODEC-246) ColognePhoneticTest.testIsEncodeEquals missing assertions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CODEC-246?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16493= 580#comment-16493580 ]=20 Gary Gregory edited comment on CODEC-246 at 5/29/18 2:30 PM: ------------------------------------------------------------- I see now, sorry. If we=C2=A0use: {noformat} Index: src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.= java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.jav= a=09(revision 1832403) +++ src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.jav= a=09(working copy) @@ -19,6 +19,7 @@ =20 import org.apache.commons.codec.EncoderException; import org.apache.commons.codec.StringEncoderAbstractTest; +import org.junit.Assert; import org.junit.Test; =20 /** @@ -142,7 +143,7 @@ {"ganz", "G\u00e4nse"}, // G=C3=83=C2=A4nse {"Miyagi", "Miyako"}}; for (final String[] element : data) { - this.getStringEncoder().isEncodeEqual(element[1], element[0]); + Assert.assertTrue(element[1] + " !=3D " + element[0], this.get= StringEncoder().isEncodeEqual(element[1], element[0])); } } {noformat} Then the test fails. Feel free to provide a PR. was (Author: garydgregory): I see now, sorry. If we=C2=A0use: {noformat} Index: src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.= java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.jav= a=09(revision 1832403) +++ src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.jav= a=09(working copy) @@ -19,6 +19,7 @@ =20 import org.apache.commons.codec.EncoderException; import org.apache.commons.codec.StringEncoderAbstractTest; +import org.junit.Assert; import org.junit.Test; =20 /** @@ -142,7 +143,7 @@ {"ganz", "G\u00e4nse"}, // G=C3=83=C2=A4nse {"Miyagi", "Miyako"}}; for (final String[] element : data) { - this.getStringEncoder().isEncodeEqual(element[1], element[0]); + Assert.assertTrue(element[1] + " !=3D " + element[0], this.get= StringEncoder().isEncodeEqual(element[1], element[0])); } } {noformat} Then the test fails. > ColognePhoneticTest.testIsEncodeEquals missing assertions > --------------------------------------------------------- > > Key: CODEC-246 > URL: https://issues.apache.org/jira/browse/CODEC-246 > Project: Commons Codec > Issue Type: Improvement > Reporter: Oscar Luis Vera P=C3=A9rez > Priority: Trivial > > The test method=C2=A0ColognePhoneticTest.isEncodeEquals=C2=A0 misses an a= ssertion to properly verify the ColognePhonetic.isEncodeEquals method.=C2= =A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)