commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CSV-225) Parse method should avoid creating a redundant BufferedReader
Date Sat, 19 May 2018 14:52:00 GMT

     [ https://issues.apache.org/jira/browse/CSV-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gary Gregory updated CSV-225:
-----------------------------
    External issue URL: https://github.com/apache/commons-csv/pull/28
     External issue ID: 28

> Parse method should avoid creating a redundant BufferedReader
> -------------------------------------------------------------
>
>                 Key: CSV-225
>                 URL: https://issues.apache.org/jira/browse/CSV-225
>             Project: Commons CSV
>          Issue Type: Improvement
>          Components: Parser
>    Affects Versions: 1.5
>            Reporter: Anson Schwabecher
>            Priority: Minor
>             Fix For: 1.6
>
>
> A redundant BufferedReader is created as the inner reader of ExtendedBufferedReader when
the CSVParser is created with:
> {{CSVParser#parse(Path, Charset, CSVFormat)}}
> Simply change over from {{Files#newBufferedReader to Files#newInputStream}}
>  
> {{public static CSVParser parse(final Path path, final Charset charset, final CSVFormat
format) throws IOException {}}
> {{    Assertions.notNull(path, "path");}}
>  {{    Assertions.notNull(format, "format");}}
>  {{    return parse(Files.newInputStream(path), charset, format);}}
>  {{}}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message