commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LANG-1390) StringUtils.join() with support for List<?> with configurable start/end indices
Date Mon, 21 May 2018 16:56:00 GMT

    [ https://issues.apache.org/jira/browse/LANG-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482727#comment-16482727
] 

Gary Gregory edited comment on LANG-1390 at 5/21/18 4:55 PM:
-------------------------------------------------------------

Hi [~joschi],

Thank you for your PR.

Please update your PR to provide 100% code coverage for the new code. For example the method:
{quote}
public static String join(final List<?> list, final char separator, final int startIndex,
final int endIndex) 
{quote}
is not covered _at all_ according to the Cobertura code coverage report.

The other new method does not get 100% code coverage and it should be quite easy to do so.

You can see the report by running {{mvn clean site}} and the viewing the site.

Also, the @since tags wrong.

Thank you!
Gary

 


was (Author: garydgregory):
Hi [~joschi],

Thank you for your PR.

Please update your PR to provide 100% code coverage for the new code. For example the method:
public static String join(final List<?> list, final char separator, final int startIndex,
final int endIndex) 
is not covered _at all_ according to the Cobertura code coverage report.

The other new method does not get 100% code coverage and it should be quite easy to do so.

You can see the report by running {{mvn clean site}} and the viewing the site.

Also, the @since tags wrong.

Thank you!
Gary

 

> StringUtils.join() with support for List<?> with configurable start/end indices
> -------------------------------------------------------------------------------
>
>                 Key: LANG-1390
>                 URL: https://issues.apache.org/jira/browse/LANG-1390
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.7
>            Reporter: Jochen Schalanda
>            Priority: Minor
>
> Apache Commons Lang offers a variant of the [StringUtils#join()|https://commons.apache.org/proper/commons-lang/javadocs/api-3.7/org/apache/commons/lang3/StringUtils.html#join-java.lang.Object:A-java.lang.String-int-int-]
function which allows specifying the start and end indices which should be used to concatenate
the elements.
> Unfortunately, this method only works for arrays (as of Apache Commons Lang 3.7) but
not for lists ([java.util.List|https://docs.oracle.com/javase/8/docs/api/java/util/List.html]).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message