commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael C (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (POOL-338) GenericObjectPool constructor throws an exception
Date Fri, 25 May 2018 04:20:00 GMT

    [ https://issues.apache.org/jira/browse/POOL-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490206#comment-16490206
] 

Michael C commented on POOL-338:
--------------------------------

The patch you posted yesterday (5/23) still does not help me. I posted *two* separate comments
on 5/12. Please revisit both again. Both offer backward compatible solutions in two different
places.

Note the source code diff in the 2nd 5/12 comment, plus the stack trace in the original bug
description. I am using the _DefaultEvictionPolicy_, so this if statement in your diff still
prevents me from using the _EvitionPolicy_ instantiated in my code, which will avoid the _instanceof_
check failure.

{{
+        // Maintain compatibility:
+        if (!BaseObjectPoolConfig.DEFAULT_EVICTION_POLICY_CLASS_NAME.equals(conf.getEvictionPolicyClassName()))
{
+            // Use the class name if it is not the default
+            setEvictionPolicyClassName(conf.getEvictionPolicyClassName());
+        } else {
+            // Otherwise, use the class
+            setEvictionPolicy(conf.getEvictionPolicy());
+        }
}}

Again, both changes in my 5/12 comments are backward compatible, and suggestion 1) and 2)
in the second comment should be reconsidered.

> GenericObjectPool constructor throws an exception
> -------------------------------------------------
>
>                 Key: POOL-338
>                 URL: https://issues.apache.org/jira/browse/POOL-338
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 2.4.2, 2.4.3, 2.5.0
>         Environment: Java 8, Liferay DXP (an OSGi environment).
>            Reporter: Michael C
>            Priority: Major
>         Attachments: commons-pool-gg.patch
>
>
> Version 2.4.3 GenericObjectPool constructor throws this exception:
> {{java.lang.IllegalArgumentException: [org.apache.commons.pool2.impl.DefaultEvictionPolicy]
does not implement EvictionPolicy}}
> {{    at org.apache.commons.pool2.impl.BaseGenericObjectPool.setEvictionPolicyClassName(BaseGenericObjectPool.java:618)}}
> {{    at org.apache.commons.pool2.impl.GenericObjectPool.setConfig(GenericObjectPool.java:318)}}
> {{    at org.apache.commons.pool2.impl.GenericObjectPool.<init>(GenericObjectPool.java:115)}}
> {{    at org.apache.commons.pool2.impl.GenericObjectPool.<init>(GenericObjectPool.java:88)}}
>  
> Version 2.5.0 throws the same exception. Version 2.4.2 or older's setEvictionPolicyClassName
method fail silently for the same reason. This line in BaseGenericObjectPool evaluates to
false for all versions:
> {{        if (policy instanceof EvictionPolicy<?>) {}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message