commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oscar Luis Vera Pérez (JIRA) <j...@apache.org>
Subject [jira] [Commented] (CODEC-246) ColognePhoneticTest.testIsEncodeEquals missing assertions
Date Mon, 28 May 2018 16:33:00 GMT

    [ https://issues.apache.org/jira/browse/CODEC-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492814#comment-16492814
] 

Oscar Luis Vera Pérez commented on CODEC-246:
---------------------------------------------

Actually, the test passes because there is no assertion. I took a look at the Cologne Phonetic
algorithm and the fix might be to change the first pair by "Mueller" and "M\u00fcller". Then
add assertTrue inside the loop for every comparison being made in the test method.

> ColognePhoneticTest.testIsEncodeEquals missing assertions
> ---------------------------------------------------------
>
>                 Key: CODEC-246
>                 URL: https://issues.apache.org/jira/browse/CODEC-246
>             Project: Commons Codec
>          Issue Type: Improvement
>            Reporter: Oscar Luis Vera Pérez
>            Priority: Trivial
>
> The test method ColognePhoneticTest.isEncodeEquals  misses an assertion to properly
verify the ColognePhonetic.isEncodeEquals method. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message