From issues-return-67509-archive-asf-public=cust-asf.ponee.io@commons.apache.org Sun Apr 29 12:15:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6657218063A for ; Sun, 29 Apr 2018 12:15:06 +0200 (CEST) Received: (qmail 62456 invoked by uid 500); 29 Apr 2018 10:15:05 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 62445 invoked by uid 99); 29 Apr 2018 10:15:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 Apr 2018 10:15:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E7B0CC204A for ; Sun, 29 Apr 2018 10:15:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id E7L0p4pyUtbX for ; Sun, 29 Apr 2018 10:15:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0B4415F30C for ; Sun, 29 Apr 2018 10:15:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 84D6DE0338 for ; Sun, 29 Apr 2018 10:15:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1DCFE21295 for ; Sun, 29 Apr 2018 10:15:00 +0000 (UTC) Date: Sun, 29 Apr 2018 10:15:00 +0000 (UTC) From: "Stefan Bodewig (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (COMPRESS-445) Zip Bomb Detection MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/COMPRESS-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457970#comment-16457970 ] Stefan Bodewig edited comment on COMPRESS-445 at 4/29/18 10:14 AM: ------------------------------------------------------------------- By now almost all {{CompressorInputStream}} s are covered (pack200 is not, but that's special anyway, {{getBytesRead}} isn't implemented either). I'll have a second look at {{SevenZipFile}} but its API is quite different from the other things we do. was (Author: bodewig): By now almost all {{CompressorInputStream}}s are covered (pack200 is not, but that's special anyway, {{getBytesRead}} isn't implemented either). I'll have a second look at {{SevenZipFile}} but its API is quite different from the other things we do. > Zip Bomb Detection > ------------------ > > Key: COMPRESS-445 > URL: https://issues.apache.org/jira/browse/COMPRESS-445 > Project: Commons Compress > Issue Type: Improvement > Components: Archivers > Reporter: PJ Fanning > Priority: Major > Labels: zip > Fix For: 1.17 > > Attachments: InputStreamStatistics.patch.gz > > > It would be a nice feature if ZipFile had support for detecting Zip Bombs. > Apache Poi has an implementation based on the java util ZipFile but this relies on Reflection and changes in Java 10 mean this code will not work in that version. > [https://github.com/apache/poi/blob/trunk/src/ooxml/java/org/apache/poi/openxml4j/util/ZipSecureFile.java] > One option would be to add equivalent change support in commons-compress and for Poi to use the commons version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)