commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <>
Subject [jira] [Commented] (CSV-223) Inconsistency between Javadoc of CSVFormat DEFAULT EXCEL
Date Sun, 01 Apr 2018 17:36:00 GMT


Gary Gregory commented on CSV-223:


Thank you for your report. We should fix the Javadoc. Would you submit a PR on GitHub please?


> Inconsistency between Javadoc of  CSVFormat DEFAULT EXCEL
> ---------------------------------------------------------
>                 Key: CSV-223
>                 URL:
>             Project: Commons CSV
>          Issue Type: Bug
>          Components: Documentation
>            Reporter: Samuel Martin
>            Priority: Minor
> According to the [Javadoc of CSVFormat|] 
>  * {{CSVFormat.DEFAULT}} includes among its settings {{withIgnoreEmptyLines(true)}}
>  * {{CSVFormat.EXCEL}} includes among its settings {{withIgnoreEmptyLines(false)}}
>  * Then, the same documentation of {{CSVFormat.EXCEL}} reads that 
> {quote}Note: this is currently like RFC4180 plus withAllowMissingColumnNames(true).{quote}
> One of these three must be wrong (both ignore empty lines, or neither ignores empty lines,
or there is another difference that needs to be mentioned).
> Edit: after checking the source code, I conclude that the latest sentence is incomplete,
and should also mention {{withIgnoreEmptyLines(false)}} as a difference with {{DEFAULT}}

This message was sent by Atlassian JIRA

View raw message