commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUMBERS-65) "RootsOfUnity" vs "nthRoot"
Date Tue, 24 Apr 2018 12:05:00 GMT

    [ https://issues.apache.org/jira/browse/NUMBERS-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449709#comment-16449709
] 

Gilles commented on NUMBERS-65:
-------------------------------

Please set the issue to "Resolved" (and please do so for all JIRA reports for which you've
fixed the code).
Thanks.

> "RootsOfUnity" vs "nthRoot"
> ---------------------------
>
>                 Key: NUMBERS-65
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-65
>             Project: Commons Numbers
>          Issue Type: Task
>          Components: complex
>            Reporter: Gilles
>            Priority: Major
>              Labels: API, delete, gsoc2018
>             Fix For: 1.0
>
>
> There is partial overlap of functionality between class {{RootsOfUnity}} and method {{nthRoot}}
(in class {{Complex}}).
> The latter is more general (any complex number) but the former allows a negative argument
(to specify clockwise ordering).
> Also, the implementations are different; it should be checked which is more accurate
(and then account for possible performance trade-offs).
> API-wise, I think that we should keep {{nthRoot}} (and delete {{RootsOfUnity}}).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message