From issues-return-67158-archive-asf-public=cust-asf.ponee.io@commons.apache.org Sat Mar 31 13:59:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0F6EE18064A for ; Sat, 31 Mar 2018 13:59:03 +0200 (CEST) Received: (qmail 12299 invoked by uid 500); 31 Mar 2018 11:59:03 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 12286 invoked by uid 99); 31 Mar 2018 11:59:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 31 Mar 2018 11:59:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7D73C180732 for ; Sat, 31 Mar 2018 11:59:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ClxA8TLLfgkT for ; Sat, 31 Mar 2018 11:59:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EFD8A5F1B4 for ; Sat, 31 Mar 2018 11:59:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7F17CE07F3 for ; Sat, 31 Mar 2018 11:59:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 187DA255F9 for ; Sat, 31 Mar 2018 11:59:00 +0000 (UTC) Date: Sat, 31 Mar 2018 11:59:00 +0000 (UTC) From: "Gilles (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MATH-1455) mvn tests fail if JDK 9 is used MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MATH-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421290#comment-16421290 ] Gilles commented on MATH-1455: ------------------------------ I was aware of that, but I didn't how to deal with it other than disabling the test, which will only hide the issue that {{FastMath}} is not a "drop-in" replacement of {{Math}} as the documentation states. The alternative of implementing the missing methods gets us back to never addressed issues: * MATH-740 * MATH-901 * MATH-1113 AFAICT, the primary purpose of the (initial) {{FastMath}} code was accuracy. As it happens, several methods were also faster, but, as the above reports showed, the name was a bad choice. First step would be to post to the "dev" ML, to see whether someone else agrees there is a fundamental issue, and is interested to fix it. > mvn tests fail if JDK 9 is used > ------------------------------- > > Key: MATH-1455 > URL: https://issues.apache.org/jira/browse/MATH-1455 > Project: Commons Math > Issue Type: Bug > Affects Versions: 4.X > Reporter: Mark Williamson > Priority: Minor > > This is essentially the JDK9 version of MATH-1156 > {code:java} > // code > Running org.apache.commons.math4.util.FastMathTest > FastMath does not implement: public static long java.lang.StrictMath.multiplyExact(long,int) > FastMath does not implement: public static double java.lang.StrictMath.fma(double,double,double) > FastMath does not implement: public static float java.lang.StrictMath.fma(float,float,float) > FastMath does not implement: public static long java.lang.StrictMath.multiplyFull(int,int) > FastMath does not implement: public static long java.lang.StrictMath.multiplyHigh(long,long) > FastMath does not implement: public static long java.lang.StrictMath.floorDiv(long,int) > FastMath does not implement: public static int java.lang.StrictMath.floorMod(long,int) > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)