From issues-return-66744-archive-asf-public=cust-asf.ponee.io@commons.apache.org Mon Feb 26 19:30:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D9CEA18064A for ; Mon, 26 Feb 2018 19:30:04 +0100 (CET) Received: (qmail 79174 invoked by uid 500); 26 Feb 2018 18:30:03 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 79163 invoked by uid 99); 26 Feb 2018 18:30:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Feb 2018 18:30:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 48FAD1802F9 for ; Mon, 26 Feb 2018 18:30:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id RG5-sXbndv1N for ; Mon, 26 Feb 2018 18:30:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 77B985FB93 for ; Mon, 26 Feb 2018 18:30:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D87BCE0222 for ; Mon, 26 Feb 2018 18:30:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 67ABC255CE for ; Mon, 26 Feb 2018 18:30:00 +0000 (UTC) Date: Mon, 26 Feb 2018 18:30:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LANG-1373?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16377= 325#comment-16377325 ]=20 ASF GitHub Bot commented on LANG-1373: -------------------------------------- Github user ottobackwards commented on the issue: https://github.com/apache/commons-lang/pull/311 =20 To do try with resources we would have to have do nothing default retur= ns right? > Stopwatch based capability for nested, named, timings in a call stack > --------------------------------------------------------------------- > > Key: LANG-1373 > URL: https://issues.apache.org/jira/browse/LANG-1373 > Project: Commons Lang > Issue Type: New Feature > Components: lang.time.* > Reporter: Otto Fowler > Assignee: Otto Fowler > Priority: Major > Labels: commons-lang, > Attachments: LANG-1373.patch > > > While working on adding some timing functionality to a Metron feature, I = came across the > Stopwatch class, but found that it didn=E2=80=99t suite my needs. > What I wanted to do was to create a timing from a top level function in o= ur Stellar dsl, and have have a group of related timings, such that the end= result was the overall time of the call, and nested timings of other calls= executed during the dsl execution of that function. These timings would al= l be named, and have a path for identification and include timing the langu= age compiler/execution as well as the function execution itself. It would b= e helpful if they were tagged in some way as well, such that the consumer c= ould filter during visitation. > So I have written StackWatch to provide this functionality, and submitted= it in a Metron PR. > From the PR description: > StackWatch > A set of utility classes under the new package stellar.common.timing have= been added. These provide the StackWatch functionality. > StackWatch provides an abstraction over the Apache Commons StopWatch clas= s that allows callers to create multiple named and possibly nested timing o= perations. > <=E2=80=A6> > This class may be more generally useful to this and other projects, but I= am not sure where it would live since we wouldn=E2=80=99t want it in commo= n. > StackWatch uses a combination of Deque and a custom Tree implementation t= o create, start and end timing operations. > A Visitor pattern is also implemented to allow for retrieving the results= after the completion of the operation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)