From issues-return-66451-archive-asf-public=cust-asf.ponee.io@commons.apache.org Wed Feb 14 19:50:10 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EDDD8180621 for ; Wed, 14 Feb 2018 19:50:09 +0100 (CET) Received: (qmail 52068 invoked by uid 500); 14 Feb 2018 18:50:08 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 52057 invoked by uid 99); 14 Feb 2018 18:50:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Feb 2018 18:50:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 70AA1C0118 for ; Wed, 14 Feb 2018 18:50:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id wHrPXSdIeHtO for ; Wed, 14 Feb 2018 18:50:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 005D85F36B for ; Wed, 14 Feb 2018 18:50:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3E6AAE00D1 for ; Wed, 14 Feb 2018 18:50:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 577E424798 for ; Wed, 14 Feb 2018 18:50:00 +0000 (UTC) Date: Wed, 14 Feb 2018 18:50:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (COMMONSRDF-49) Make AbstractRDFParser serializable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/COMMONSRDF-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364601#comment-16364601 ] ASF GitHub Bot commented on COMMONSRDF-49: ------------------------------------------ Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/43 > Make AbstractRDFParser serializable > ----------------------------------- > > Key: COMMONSRDF-49 > URL: https://issues.apache.org/jira/browse/COMMONSRDF-49 > Project: Apache Commons RDF > Issue Type: New Feature > Components: simple > Affects Versions: 0.3.0 > Reporter: Stian Soiland-Reyes > Assignee: Stian Soiland-Reyes > Priority: Major > Labels: parser > Fix For: 0.6.0 > > > Raised by [~p_ansell] in [pull request 25|(https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85436754] > {quote} > The use of optional here as a field type makes it impossible to serialise. Need to have the raw values stored in fields if you want to support serialisation in the future, which should otherwise be possible. > {quote} > The suggestion is to avoid {{Optional}} in the private fields of {{AbstractRDFParser}} so it can be serialized - it can still be {{Optional}} in the accessor methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)