From issues-return-66552-archive-asf-public=cust-asf.ponee.io@commons.apache.org Wed Feb 21 06:52:27 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 29C2A18061A for ; Wed, 21 Feb 2018 06:52:26 +0100 (CET) Received: (qmail 51747 invoked by uid 500); 21 Feb 2018 05:52:26 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 51731 invoked by uid 99); 21 Feb 2018 05:52:25 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Feb 2018 05:52:25 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2C03DDFC29; Wed, 21 Feb 2018 05:52:23 +0000 (UTC) From: kinow To: issues@commons.apache.org Reply-To: issues@commons.apache.org References: In-Reply-To: Subject: [GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na... Content-Type: text/plain Message-Id: <20180221055224.2C03DDFC29@git1-us-west.apache.org> Date: Wed, 21 Feb 2018 05:52:23 +0000 (UTC) Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/311 Pull request looks good. Toyed with the code a bit (https://gist.github.com/kinow/c0873daf069c2e64bc69d6305400e610), and I like the current design. @ottobackwards let's ask in the ML if anybody else would like to review it, and if nobody replies by the weekend, consider it merged. During the merge, I'd like to squash the commits to keep the commit history/tree simpler. Would you mind squashing the commits and updating the pull request to one single commit (or a few if you think it's necessary), please? Cheers B ---