commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Iurii (JIRA)" <>
Subject [jira] [Commented] (LANG-1368) HashCodeBuilder.append incorrect behavior with chains of nulls
Date Tue, 20 Feb 2018 05:25:00 GMT


Iurii commented on LANG-1368:

Unfortunately I don't have any Mac machine available to test that. Please let me know if you
find out some more info on this issue.

And if someone is able to test that on Mac with eclipse, I guess that would be great also.

> HashCodeBuilder.append incorrect behavior with chains of nulls
> --------------------------------------------------------------
>                 Key: LANG-1368
>                 URL:
>             Project: Commons Lang
>          Issue Type: Bug
>            Reporter: Ryan Wisnesky
>            Priority: Minor
> I have a 7-way choice/sum/variant class, so that 6 of its 7 fields are null in each object
of that class.  When using HashCodeBuilder's reflective hashCode, a 10k line java project
works correctly.  When using HashCodeBuilder.append instead, sequential calls to append with
a null argument cause the returned hashCode to be inconsistent with EqualsBuilder.  Correct
behavior can be restored by appending a dummy non-null field initially:
> 	new HashCodeBuilder()
> 					.append(true) //bad return value without this dummy call
> 					.append(chc1)
> ...
> 					.append(chc7)
> 					.toHashCode();

This message was sent by Atlassian JIRA

View raw message