commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Osman Shoukry (JIRA)" <>
Subject [jira] [Commented] (LANG-985) ToStringBuilder reliably handle OpenPojo @BusinessKey annotated instances
Date Mon, 12 Feb 2018 22:01:00 GMT


Osman Shoukry commented on LANG-985:

If you use OpenPojo's toString it won't cause an issue while trying to call "hashCode" which
is the default implementation for toString on Object as OpenPojo's toString doesn't call hashCode.

> ToStringBuilder reliably handle OpenPojo @BusinessKey annotated instances
> -------------------------------------------------------------------------
>                 Key: LANG-985
>                 URL:
>             Project: Commons Lang
>          Issue Type: Wish
>          Components: lang.builder.*
>            Reporter: David Green
>            Priority: Minor
>              Labels: features
>             Fix For: Discussion
> We use Google's OpenPojo library, annotating DTOs and persistence entities with @BusinessKey
in order to remove boilerplate hashcode() and equals().
> I recently started noticing toString() was throwing exceptions when I didn't populate
@BusinessKey annotated field(s) as I was using the Null Object Pattern.  A workaround was
to populate dummy values but there's a risk this could be considered a real value further
down the line, so looked for an alternative solution and came up with the following extending
> {code}
> import org.apache.commons.lang3.builder.StandardToStringStyle;
> import org.apache.commons.lang3.builder.ToStringStyle;
> public class CustomToStringStyle extends StandardToStringStyle {
>     public static final ToStringStyle OPENPOJO_SAFE_STYLE = createOpenPojoSafeStyle();
>     /**
>      * Works better with {@link} annotated
OpenPojo classes.
>      * 
>      * This instance does not call {@link ToStringStyle}.register(...)
>      * which can throw a {@link} 
> 	 * if the key hasn't been populated, for example if you used the Null Object Pattern.
>      */    
>     private static ToStringStyle createOpenPojoSafeStyle() {
>         final StandardToStringStyle style = new StandardToStringStyle();
>         style.setUseClassName(false);
>         style.setUseIdentityHashCode(false);
>         return style;
>     }
> }
> {code}
> Used as follows:
> {code}
>     @Override
>     public String toString() {
>         return ToStringBuilder.reflectionToString(this, CustomToStringStyle.OPENPOJO_SAFE_STYLE);
>     }
> {code}
> I realise this doesn't handle recursion in fields because it skips over ToStringStyle.register(..)
but this suffices for our use case right now - perhaps an alternative implementation overriding
register() that uses a List (with documented performance penalty) could be added.
> Is there anything already in Commons that could do this? If not we would like this to
be considered for inclusion in commons lang (happy to help out with development), potentially
with implementation improvements by those who know the code base better.

This message was sent by Atlassian JIRA

View raw message