commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kinow <...@git.apache.org>
Subject [GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na...
Date Wed, 21 Feb 2018 05:52:23 GMT
Github user kinow commented on the issue:

    https://github.com/apache/commons-lang/pull/311
  
    Pull request looks good. Toyed with the code a bit (https://gist.github.com/kinow/c0873daf069c2e64bc69d6305400e610),
and I like the current design.
    
    @ottobackwards let's ask in the ML if anybody else would like to review it, and if nobody
replies by the weekend, consider it merged. During the merge, I'd like to squash the commits
to keep the commit history/tree simpler. Would you mind squashing the commits and updating
the pull request to one single commit (or a few if you think it's necessary), please?
    
    Cheers
    B


---

Mime
View raw message