From issues-return-66052-archive-asf-public=cust-asf.ponee.io@commons.apache.org Thu Jan 25 19:18:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 58E65180651 for ; Thu, 25 Jan 2018 19:18:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 49066160C50; Thu, 25 Jan 2018 18:18:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 977C8160C3D for ; Thu, 25 Jan 2018 19:18:04 +0100 (CET) Received: (qmail 60916 invoked by uid 500); 25 Jan 2018 18:18:03 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 60905 invoked by uid 99); 25 Jan 2018 18:18:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jan 2018 18:18:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1C288C1274 for ; Thu, 25 Jan 2018 18:18:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.711 X-Spam-Level: X-Spam-Status: No, score=-108.711 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id SzAPxMepDj-x for ; Thu, 25 Jan 2018 18:18:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2F1F75FC0E for ; Thu, 25 Jan 2018 18:18:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6D1A3E0F6D for ; Thu, 25 Jan 2018 18:18:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 269CF240EE for ; Thu, 25 Jan 2018 18:18:00 +0000 (UTC) Date: Thu, 25 Jan 2018 18:18:00 +0000 (UTC) From: "Gilles (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (RNG-46) Benign incompatibility (?) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/RNG-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339586#comment-16339586 ] Gilles commented on RNG-46: --------------------------- As suggested by Oliver, I've added an explanation in "changes.xml" (commit a242b59f78d93940e010514df2b43cf1a66df34a in "master"). > Benign incompatibility (?) > -------------------------- > > Key: RNG-46 > URL: https://issues.apache.org/jira/browse/RNG-46 > Project: Commons RNG > Issue Type: Sub-task > Reporter: Gilles > Priority: Blocker > Labels: compatibility, incompatibility > Fix For: 1.1 > > > Clirr reports this error: > {{Removed org.apache.commons.rng.sampling.distribution.SamplerBase from the list of superclasses}} > for this class: > {{org.apache.commons.rng.sampling.distribution.BoxMullerLogNormalSampler}} > It is quite true. > However, no functionality inherited from {{SamplerBase}} could have been used since a {{null}} was passed to its constructor (i.e. any call to a method from the base class would trigger a {{NullPointerException}}). > Moreover: > * {{SamplerBase}} is only meant for internal usage, > * it only contains {{protected}} methods, > * {{BoxMullerLogNormalSampler}} is going to be flagged as {{@deprecated}} in the next release. > Hence, I think that it is quite safe to release a 1.1 version (i.e. no change in major number!) despite this incompatibility. > Please confirm. > See also the [discussion on the "dev" ML|http://markmail.org/message/24t4v2bsh5x366fe]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)