From issues-return-66071-archive-asf-public=cust-asf.ponee.io@commons.apache.org Fri Jan 26 15:01:36 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id A0894180657 for ; Fri, 26 Jan 2018 15:01:36 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 90FB1160C3E; Fri, 26 Jan 2018 14:01:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D64B4160C20 for ; Fri, 26 Jan 2018 15:01:35 +0100 (CET) Received: (qmail 82619 invoked by uid 500); 26 Jan 2018 14:01:35 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 82608 invoked by uid 99); 26 Jan 2018 14:01:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jan 2018 14:01:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 68A18C2462 for ; Fri, 26 Jan 2018 14:01:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id wuWKgud88CE0 for ; Fri, 26 Jan 2018 14:01:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 66AEF5F177 for ; Fri, 26 Jan 2018 14:01:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 86D7AE0F6D for ; Fri, 26 Jan 2018 14:01:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 23EBF240F6 for ; Fri, 26 Jan 2018 14:01:00 +0000 (UTC) Date: Fri, 26 Jan 2018 14:01:00 +0000 (UTC) From: "Eric Barnhill (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (NUMBERS-48) Unreachable statements in Complex.abs() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/NUMBERS-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341085#comment-16341085 ] Eric Barnhill commented on NUMBERS-48: -------------------------------------- Ah right. I just forked commons-statistics so my head was in the wrong place. > Unreachable statements in Complex.abs() > --------------------------------------- > > Key: NUMBERS-48 > URL: https://issues.apache.org/jira/browse/NUMBERS-48 > Project: Commons Numbers > Issue Type: Bug > Reporter: David Nickerson > Priority: Minor > Labels: easyfix, newbie, patch > Fix For: 1.0 > > Attachments: complex_abs.patch > > > This return statement in Complex.abs() is unreachable: > {code:java} > if (FastMath.abs(real) < FastMath.abs(imaginary)) { > if (imaginary == 0.0) { > return FastMath.abs(real); > } > {code} > If imaginary == 0, then there's no way that the preceding condition would be true. There are two similar inner 'if' statements that were accidentally switched. Returned values are still correct, but performance suffers. > The attached patch switches these back. Note that we're still protected from dividing by zero. -- This message was sent by Atlassian JIRA (v7.6.3#76005)