commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMPRESS-429) Expose whether ZIP entry name & comment come from Unicode extra field
Date Fri, 05 Jan 2018 23:28:00 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314123#comment-16314123
] 

ASF GitHub Bot commented on COMPRESS-429:
-----------------------------------------

Github user dalbani commented on a diff in the pull request:

    https://github.com/apache/commons-compress/pull/56#discussion_r160002542
  
    --- Diff: src/main/java/org/apache/commons/compress/archivers/zip/ZipUtil.java ---
    @@ -239,6 +239,7 @@ static void setNameAndCommentFromExtraFields(final ZipArchiveEntry
ze,
                                                                originalNameBytes);
             if (newName != null && !originalName.equals(newName)) {
    --- End diff --
    
    When I think about it, I would remove the second test in this `if`, so that the Unicode
field always have "priority" over the original name as source.
    Scenario where it would matter is when the `originalName` contains a non ASCII value (which
is properly decoded) and which matches with the Unicode field value.


> Expose whether ZIP entry name & comment come from Unicode extra field
> ---------------------------------------------------------------------
>
>                 Key: COMPRESS-429
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-429
>             Project: Commons Compress
>          Issue Type: Improvement
>            Reporter: Damiano Albani
>            Priority: Minor
>              Labels: Unicode, ZIP
>             Fix For: 1.16
>
>
> It is known fact that detecting the encoding of the name/comment of ZIP entries is a
messy process. And that the general purpose bit 11 is often unreliable.
> Only the so-called Unicode extra field (if present) can be trusted to reliably determine
a ZIP entry name & comment, as far as I understand.
> But the current API of Commons Compress doesn't (easily) expose in which situation the
ZIP archive reader is.
> That's why I propose to add a couple of new getter/setter-exposed fields to {{ZipArchiveEntry}},
e.g.:
> {noformat}
> boolean hasUnicodeName
> boolean hasUnicodeComment
> {noformat}
> This way it can be easily determined if the value returned by {{ZipArchiveEntry::getName}}
or {{ZipArchiveEntry::getComment}} can be trusted. Or if it needs some "character encoding
sniffing" of sorts.
> What do you think?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message