Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CC278200D73 for ; Tue, 26 Dec 2017 10:56:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CADE7160C00; Tue, 26 Dec 2017 09:56:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1C2CE160C31 for ; Tue, 26 Dec 2017 10:56:05 +0100 (CET) Received: (qmail 13759 invoked by uid 500); 26 Dec 2017 09:56:05 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 13734 invoked by uid 99); 26 Dec 2017 09:56:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Dec 2017 09:56:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7A555C174C for ; Tue, 26 Dec 2017 09:56:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.011 X-Spam-Level: X-Spam-Status: No, score=-100.011 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id MzfZeFMaMfb3 for ; Tue, 26 Dec 2017 09:56:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 31AD25F576 for ; Tue, 26 Dec 2017 09:56:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 39B56E0F61 for ; Tue, 26 Dec 2017 09:56:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 61033240F6 for ; Tue, 26 Dec 2017 09:56:00 +0000 (UTC) Date: Tue, 26 Dec 2017 09:56:00 +0000 (UTC) From: "Anders Thulin (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (COMPRESS-434) Add test case/documentation for specific GzipCompressorInputStream use case MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 26 Dec 2017 09:56:07 -0000 Anders Thulin created COMPRESS-434: -------------------------------------- Summary: Add test case/documentation for specific GzipCompressorInputStream use case Key: COMPRESS-434 URL: https://issues.apache.org/jira/browse/COMPRESS-434 Project: Commons Compress Issue Type: Improvement Components: Compressors Environment: Only observed this for Compress 1.15; have not checked earlier versions. Reporter: Anders Thulin Priority: Minor The constructor for GzipCompressedInputStream() allows two forms of creation: one with the decompressConcatenated parameter true, and one with it false. The second case (false) does not have any accompanying test case. The only testcase present is testConcatenatedStreamsReadFully, which uses decompressConcatenated = true. *Suggestion 1: Provide a test case for the decompressConcatenated = false use case to test that separate gzip members are extracted from the same InputStream. Existing test data ('multiple.gz') might be used for this. (I'm assuming RFC1952 compliance here ... see below) The lack of code indirectly strikes against practical use of this form of constructor: it is not at all obvious from the JavaDoc how concatenated archives are extracted while retaining their independent identity. * Suggestion 2: Add sample code for this usecase to JavaDoc. * Suggestion 3: If GzipCompressedInputStream is intended to provide support for RFC1952-compatible streams, please document it. Alternatively, document that it isn't. -- This message was sent by Atlassian JIRA (v6.4.14#64029)