Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 28 Dec 2017 09:17:03 +0000 (UTC)
From: "Stefan Bodewig (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13037723.1485357238000.540382.1514452623330@Atlassian.JIRA>
In-Reply-To: <JIRA.13037723.1485357238000@Atlassian.JIRA>
References: <JIRA.13037723.1485357238000@Atlassian.JIRA> <JIRA.13037723.1485357238748@jira-lw-us.apache.org>
Subject: [jira] [Commented] (COMPRESS-380) Support for ENHANCED_DEFLATED
 (Deflate64) in ZIP files
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 28 Dec 2017 09:17:24 -0000


    [ https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305196#comment-16305196 ] 

Stefan Bodewig commented on COMPRESS-380:
-----------------------------------------

@chalmagr84 many thanks. I'm still comparing your code with the one in zlib and not completely through. This looks really good.

I'd probably change the package name from ...compressors.zip to compressors.deflate64 (and maybe add a standalone {{CompressorInputStream}} as well) - and certainly add the license headers and some javadocs. I can do all of these steps myself unless you want to update the patch.

> Support for ENHANCED_DEFLATED (Deflate64) in ZIP files
> ------------------------------------------------------
>
>                 Key: COMPRESS-380
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-380
>             Project: Commons Compress
>          Issue Type: New Feature
>            Reporter: Dawid Weiss
>             Fix For: 1.16
>
>         Attachments: archive-deflate.zip, archive-deflate64.zip, compress-380.diff, hello.world
>
>
> Some of the (large) ZIP files we try to process currently will throw this:
> {code}
> UnsupportedZipFeatureException: unsupported feature method 'ENHANCED_DEFLATED' 
> {code}
> which is a bummer since JDK's implementation also doesn't support Deflate64. This seems to be PKWare's extensions, although code to decrypt it exists in zlib (and is appropriately licensed, I believe).
> https://github.com/madler/zlib/tree/master/contrib/infback9


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)