Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Tue, 19 Dec 2017 13:20:00 +0000 (UTC)
From: "Zoltan Levardy (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12916933.1448880680000.492594.1513689600297@Atlassian.JIRA>
In-Reply-To: <JIRA.12916933.1448880680000@Atlassian.JIRA>
References: <JIRA.12916933.1448880680000@Atlassian.JIRA> <JIRA.12916933.1448880680901@jira-lw-us.apache.org>
Subject: [jira] [Commented] (VFS-590) SFTP moveTo operation might fail on
 permission checks even if the operation itself might succeed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 19 Dec 2017 13:20:08 -0000


    [ https://issues.apache.org/jira/browse/VFS-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296774#comment-16296774 ] 

Zoltan Levardy commented on VFS-590:
------------------------------------

is this something solvable with jsch and vfs?

> SFTP moveTo operation might fail on permission checks even if the operation itself might succeed
> ------------------------------------------------------------------------------------------------
>
>                 Key: VFS-590
>                 URL: https://issues.apache.org/jira/browse/VFS-590
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>            Reporter: L
>
> Continuing with SFTP moveTo, see VFS-588 and VFS-589 for more details.
> The permission checks that VFS performs during moveTo() can result in failure. 
> org.apache.commons.vfs2.provider.AbstractFileObject.moveTo(final FileObject destFile) starts with some checks:
> {code:java}
>     @Override
>     public void moveTo(final FileObject destFile) throws FileSystemException
>     {
>         if (canRenameTo(destFile))
>         {
>             if (!getParent().isWriteable())
>             {
>                 throw new FileSystemException("vfs.provider/rename-parent-read-only.error",
>                         getName(),
>                         getParent().getName());
>             }
>         }
>         else
>         {
>             if (!isWriteable())
>             {
>                 throw new FileSystemException("vfs.provider/rename-read-only.error", getName());
>             }
>         }
> {code}
> The problem is: isWriteable() might fail or even hang. Performing moveTo without this check might successfully rename the file.
> isWriteable() in case of SFTP can fail if the server disables SSH channelExec. Or if it does not support "id" command.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)