Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2AB23200D57 for ; Mon, 11 Dec 2017 12:00:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 293AB160C10; Mon, 11 Dec 2017 11:00:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6F791160C13 for ; Mon, 11 Dec 2017 12:00:04 +0100 (CET) Received: (qmail 79212 invoked by uid 500); 11 Dec 2017 11:00:03 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 79201 invoked by uid 99); 11 Dec 2017 11:00:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Dec 2017 11:00:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 29059C465A for ; Mon, 11 Dec 2017 11:00:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id KjR5FvxicNN5 for ; Mon, 11 Dec 2017 11:00:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D871A5F3D0 for ; Mon, 11 Dec 2017 11:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 206EAE0EF6 for ; Mon, 11 Dec 2017 11:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id CC239212F5 for ; Mon, 11 Dec 2017 11:00:00 +0000 (UTC) Date: Mon, 11 Dec 2017 11:00:00 +0000 (UTC) From: "zhipengxu (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IO-386) FileUtils.doCopyFile uses different methods to check the file sizes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 11 Dec 2017 11:00:05 -0000 [ https://issues.apache.org/jira/browse/IO-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285761#comment-16285761 ] zhipengxu commented on IO-386: ------------------------------ Can we save the length before copy really start and compare it with the new generated file ? Does it really cannot be fixed? > FileUtils.doCopyFile uses different methods to check the file sizes > ------------------------------------------------------------------- > > Key: IO-386 > URL: https://issues.apache.org/jira/browse/IO-386 > Project: Commons IO > Issue Type: Bug > Reporter: Sebb > Priority: Minor > > FileUtils.doCopyFile uses FileChannel.size() to measure the input file length at the start, and File.length() to compare the lengths at the end. > This is inconsistent. > If there is a good reason for this it should be documented, otherwise it should probably use the same method for all the checks. > [Note: is FileChannel.size() accurate if the file has not been flushed?] -- This message was sent by Atlassian JIRA (v6.4.14#64029)