commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Juntunen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1436) PolygonsSet Infinite Lines and SubOrientedPoint Tolerance Issues
Date Sat, 23 Dec 2017 19:29:00 GMT

    [ https://issues.apache.org/jira/browse/MATH-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302551#comment-16302551
] 

Matt Juntunen commented on MATH-1436:
-------------------------------------

I split the pull request in two and added the new links in the issue description. There's
also a few more unit tests and more comments. And better commit messages, too :-)

Let me know if this will work or not. Thanks.

> PolygonsSet Infinite Lines and SubOrientedPoint Tolerance Issues
> ----------------------------------------------------------------
>
>                 Key: MATH-1436
>                 URL: https://issues.apache.org/jira/browse/MATH-1436
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 4.0, 3.5, 3.6, 3.6.1
>            Reporter: Matt Juntunen
>             Fix For: 4.0, 3.6.1
>
>
> These are two separate issues that I found while using the partitioning code from 3.5
to work with complex solid models. The issues are:
> 1. org.apache.commons.math[34].geometry.euclidean.oned.SubOrientedPoint uses a hardcoded
tolerance of 1.0e-10 instead of the tolerance from the parent hyperplane. This causes issues
when working with a tolerance other than the default.
> 2. org.apache.commons.math[34].geometry.euclidean.twod.PolygonsSet fails on infinite
line segments. An IndexOutOfBoundsException is thrown when a PolygonsSet is created with a
single infinite SubLine as a boundary and a NullPointerException is thrown when one is created
with a mix of finite and finite boundaries.
> I will be attaching a pull request shortly with fixes and unit tests.
> UPDATE:
> -Pull request for v4.0: [https://github.com/apache/commons-math/pull/70]-
> -Pull request for v3.6.x: [https://github.com/apache/commons-math/pull/71]- (removed;
no future releases planned for v3.x)
> UPDATE [2017-12-23]:
> Split initial pull request into two separate ones:
> - SubOrientedPoint changes: [https://github.com/apache/commons-math/pull/72]
> - PolygonsSet changes: [https://github.com/apache/commons-math/pull/73 ]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message