commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1436) PolygonsSet Infinite Lines and SubOrientedPoint Tolerance Issues
Date Fri, 22 Dec 2017 11:04:00 GMT

    [ https://issues.apache.org/jira/browse/MATH-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301260#comment-16301260
] 

Gilles commented on MATH-1436:
------------------------------

bq. do you mean to close this issue and create two new ones with separate pull requests

For future work, one report per issue is the best option.

bq. just to create two pull requests for this one issue

That'll be fine but please make the log message (for each issue) a little more explicit than
"adding fixes". ;)

bq. I'm using the geometry code from v3.6.1 quite a bit in my current project \[...\] So,
I'd be very interested in helping out

Currently, you're probably the one with the most expertise with this part of the library;
thanks a lot for the offer.

> PolygonsSet Infinite Lines and SubOrientedPoint Tolerance Issues
> ----------------------------------------------------------------
>
>                 Key: MATH-1436
>                 URL: https://issues.apache.org/jira/browse/MATH-1436
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 4.0, 3.5, 3.6, 3.6.1
>            Reporter: Matt Juntunen
>             Fix For: 4.0, 3.6.1
>
>
> These are two separate issues that I found while using the partitioning code from 3.5
to work with complex solid models. The issues are:
> 1. org.apache.commons.math[34].geometry.euclidean.oned.SubOrientedPoint uses a hardcoded
tolerance of 1.0e-10 instead of the tolerance from the parent hyperplane. This causes issues
when working with a tolerance other than the default.
> 2. org.apache.commons.math[34].geometry.euclidean.twod.PolygonsSet fails on infinite
line segments. An IndexOutOfBoundsException is thrown when a PolygonsSet is created with a
single infinite SubLine as a boundary and a NullPointerException is thrown when one is created
with a mix of finite and finite boundaries.
> I will be attaching a pull request shortly with fixes and unit tests.
> UPDATE:
> Pull request for v4.0: https://github.com/apache/commons-math/pull/70
> -Pull request for v3.6.x: https://github.com/apache/commons-math/pull/71 - (removed;
no future releases planned for v3.x)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message