commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Juntunen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1436) PolygonsSet Infinite Lines and SubOrientedPoint Tolerance Issues
Date Fri, 22 Dec 2017 03:27:00 GMT

    [ https://issues.apache.org/jira/browse/MATH-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300923#comment-16300923
] 

Matt Juntunen commented on MATH-1436:
-------------------------------------

Hi. Thanks for the feedback. When you say to create two separate patches, do you mean to close
this issue and create two new ones with separate pull requests or just to create two pull
requests for this one issue?

That's good to know about the 3.x branch. I'll remove that pull request.

Reading the mailing list thread you posted was quite informative. That gave me a much better
picture for the current state of the project. I'm using the geometry code from v3.6.1 quite
a bit in my current project and I keep running up against issues and things I'd like to update
(specifically in the partitioning package). So, I'd be very interested in helping out if this
code is going to be refactored at all.

> PolygonsSet Infinite Lines and SubOrientedPoint Tolerance Issues
> ----------------------------------------------------------------
>
>                 Key: MATH-1436
>                 URL: https://issues.apache.org/jira/browse/MATH-1436
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 4.0, 3.5, 3.6, 3.6.1
>            Reporter: Matt Juntunen
>             Fix For: 4.0, 3.6.1
>
>
> These are two separate issues that I found while using the partitioning code from 3.5
to work with complex solid models. The issues are:
> 1. org.apache.commons.math[34].geometry.euclidean.oned.SubOrientedPoint uses a hardcoded
tolerance of 1.0e-10 instead of the tolerance from the parent hyperplane. This causes issues
when working with a tolerance other than the default.
> 2. org.apache.commons.math[34].geometry.euclidean.twod.PolygonsSet fails on infinite
line segments. An IndexOutOfBoundsException is thrown when a PolygonsSet is created with a
single infinite SubLine as a boundary and a NullPointerException is thrown when one is created
with a mix of finite and finite boundaries.
> I will be attaching a pull request shortly with fixes and unit tests.
> UPDATE:
> Pull request for v4.0: https://github.com/apache/commons-math/pull/70
> Pull request for v3.6.x: https://github.com/apache/commons-math/pull/71



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message