commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno P. Kinoshita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IMAGING-123) remove duplicated lines in T4AndT6Compression
Date Thu, 28 Dec 2017 12:00:09 GMT

    [ https://issues.apache.org/jira/browse/IMAGING-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305376#comment-16305376
] 

Bruno P. Kinoshita commented on IMAGING-123:
--------------------------------------------

Patch looks good to me. Did a `mvn clean site`, confirmed CPD is reporting it. Then applied
the patch with `patch -p0 < ~/patch`. No issues applying the patch. All tests passing,
coverage OK, CPD happy now. Reviewed the code with gitk and it looks correct.

Fixed one missing indentation space, then replaced tabs by spaces. Finally, added an entry
to the changes.xml, and committed in c5ca63fe3864a0fd7673641d08049741e94a0287.

Thank you for your contribution [~jenskapitza]!
Bruno

ps: looks like the same can be done with the decompress methods, so if anyone is keen to fix
another CPD issue (-: patches welcome!

> remove duplicated lines in T4AndT6Compression
> ---------------------------------------------
>
>                 Key: IMAGING-123
>                 URL: https://issues.apache.org/jira/browse/IMAGING-123
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: Format: TIFF
>    Affects Versions: 1.x
>            Reporter: Jens Kapitza
>            Assignee: Bruno P. Kinoshita
>            Priority: Minor
>              Labels: patch
>             Fix For: 1.0
>
>         Attachments: T4AndT6Compression.java.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> CDP message



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message