Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CB6B7200D47 for ; Sat, 25 Nov 2017 11:06:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C9EF3160C03; Sat, 25 Nov 2017 10:06:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1B01A160C00 for ; Sat, 25 Nov 2017 11:06:09 +0100 (CET) Received: (qmail 59780 invoked by uid 500); 25 Nov 2017 10:06:09 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 59769 invoked by uid 99); 25 Nov 2017 10:06:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 Nov 2017 10:06:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 808F618061F for ; Sat, 25 Nov 2017 10:06:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id MLd0VL5M1OuN for ; Sat, 25 Nov 2017 10:06:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4E8D25FB4E for ; Sat, 25 Nov 2017 10:06:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 49FB6E0E53 for ; Sat, 25 Nov 2017 10:06:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DD225241A6 for ; Sat, 25 Nov 2017 10:06:00 +0000 (UTC) Date: Sat, 25 Nov 2017 10:06:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (COMPRESS-430) Synchronize iteration on synchronized list in ParallelScatterZipCreator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 25 Nov 2017 10:06:11 -0000 [ https://issues.apache.org/jira/browse/COMPRESS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265656#comment-16265656 ] ASF GitHub Bot commented on COMPRESS-430: ----------------------------------------- Github user coveralls commented on the issue: https://github.com/apache/commons-compress/pull/57 [![Coverage Status](https://coveralls.io/builds/14361284/badge)](https://coveralls.io/builds/14361284) Coverage increased (+0.05%) to 85.932% when pulling **c0499042c2778161d6cecd54357adb6ea9595132 on kinow:synchronize-iteration-of-synchronized-list-1** into **10ff1c341d37da1cdb2a9ecb280a7e73670c00f5 on apache:master**. > Synchronize iteration on synchronized list in ParallelScatterZipCreator > ----------------------------------------------------------------------- > > Key: COMPRESS-430 > URL: https://issues.apache.org/jira/browse/COMPRESS-430 > Project: Commons Compress > Issue Type: Bug > Components: Archivers > Affects Versions: 1.15 > Reporter: Bruno P. Kinoshita > Priority: Minor > Labels: concurrency > Fix For: 1.16 > > > Following what is defined in the [Collections javadoc|https://docs.oracle.com/javase/9/docs/api/java/util/Collections.html#synchronizedList(java.util.List)], it might be a good idea to synchronize when iterating the stream list, that is created with Collections.synchronizedList. > This work originated after the pull request submitted to VALIDATOR-434, and searching other components in commons using similar method to create lists but not synchronizing the iteration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)