Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 20 Nov 2017 09:03:00 +0000 (UTC)
From: "Bruno P. Kinoshita (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13113136.1509393971000.278511.1511168580280@Atlassian.JIRA>
In-Reply-To: <JIRA.13113136.1509393971000@Atlassian.JIRA>
References: <JIRA.13113136.1509393971000@Atlassian.JIRA> <JIRA.13113136.1509393971839@jira-lw-us.apache.org>
Subject: [jira] [Commented] (IMAGING-205) Imaging (Apache Sanselan) produces
 "odd offsets" in (EXIF) metadata
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 20 Nov 2017 09:03:09 -0000


    [ https://issues.apache.org/jira/browse/IMAGING-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258968#comment-16258968 ] 

Bruno P. Kinoshita commented on IMAGING-205:
--------------------------------------------

Hi Joakim,

So I've found a way to get exiftool's htmldump to have no odd offsets. Push a single commit here https://github.com/kinow/commons-imaging/tree/tiff-odd-offsets-1

I slowly read the code, and found that these two parts were simply adding the length in bytes of the field plus a previous offset. Which could result in odd offsets. It would help me a lot if you were able to checkout my branch, `mvn clean package`, use the jar in your app, and let me know if that works fine for you.

Once I realized where the odd bytes were coming from, this seemed like the simplest solution (occam's razor). But before we consider this naive solution as a definitive solution, I'd like to:

* have a confirmation that the odd bytes is gone and the metadata and image are still *valid/good/correct/etc*
* have a better understand of the different between a TIFFOutputItem and TIFFOutputField. The latter has a method, writeField, that seems to be correctly handling offsets oddness.
* write a unit test
* find the parts of the specification that define that behaviour, and add links to them here, in the unit test, and in the javadoc of the class where the fix is applied

> Imaging (Apache Sanselan) produces "odd offsets" in (EXIF) metadata
> -------------------------------------------------------------------
>
>                 Key: IMAGING-205
>                 URL: https://issues.apache.org/jira/browse/IMAGING-205
>             Project: Commons Imaging
>          Issue Type: Bug
>          Components: imaging.*
>            Reporter: Joakim Knudsen
>            Assignee: Bruno P. Kinoshita
>            Priority: Critical
>         Attachments: 20171030_214812.jpg, 20171030_214812_copy_desktop.JPG, 20171030_21481_COPY.jpg, DSC_5506.JPG, DSC_5506_copy_desktop.JPG, Gaboxjellyfish-changedexifmetadata.jpg, Gaboxjellyfish.jpg, after.html, before.html
>
>
> I'm using the "last stable version" of Apache Sanselan 0.97 in an Android project (app). I have not upgraded to Commons Imaging yet, since the website says there is no stable release yet. Meanwhile, there are bugs in Sanselan. 
> If I run the [sample code method WriteExifMetadataExample.changeExifMetadata|http://svn.apache.org/repos/asf/commons/proper/sanselan/trunk/src/test/java/org/apache/sanselan/sampleUsage/WriteExifMetadataExample.java?p=820841] on an image, which updates the Apterture and GPS tags, the resulting image fails to validate (through Phil Harvey's [ExifTool software|https://sno.phy.queensu.ca/~phil/exiftool/]):
> {noformat}
> > exiftool.exe -validate -error -warning -a "..\20171030_21481_COPY.jpg"
> Validate                        : 19 Warnings (17 minor)
> Warning                         : [minor] Odd offset for IFD0 tag 0x010f
> Warning                         : [minor] Odd offset for IFD0 tag 0x011a
> Warning                         : [minor] Odd offset for IFD0 tag 0x011b
> Warning                         : [minor] Odd offset for IFD0 tag 0x0131
> Warning                         : [minor] Odd offset for IFD0 tag 0x0132
> Warning                         : [minor] Odd offset for ExifIFD tag 0x829a
> Warning                         : [minor] Odd offset for ExifIFD tag 0x829d
> Warning                         : [minor] Odd offset for ExifIFD tag 0x9003
> Warning                         : [minor] Odd offset for ExifIFD tag 0x9004
> Warning                         : [minor] Odd offset for ExifIFD tag 0x9202
> Warning                         : [minor] Odd offset for ExifIFD tag 0x9205
> Warning                         : [minor] Odd offset for ExifIFD tag 0x920a
> Warning                         : [minor] Odd offset for ExifIFD tag 0x9286
> Warning                         : Non-standard count (1) for GPS tag 0x0001 GPSLatitudeRef
> Warning                         : [minor] Odd offset for GPS tag 0x0002
> Warning                         : Non-standard count (1) for GPS tag 0x0003 GPSLongitudeRef
> Warning                         : [minor] Odd offset for GPS tag 0x0004
> Warning                         : [minor] Odd offset for IFD1 tag 0x011a
> Warning                         : [minor] Odd offset for IFD1 tag 0x011b
> {noformat}
> I need some advice on how to proceed here. Since Sanselan does not appear to do what it should (even on very basic metadata editing), am I correct to assume that the current version of Commons Imaging does a better job? :-)


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)