commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMPRESS-430) Synchronize iteration on synchronized list in ParallelScatterZipCreator
Date Sat, 25 Nov 2017 10:03:00 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265654#comment-16265654
] 

ASF GitHub Bot commented on COMPRESS-430:
-----------------------------------------

GitHub user kinow opened a pull request:

    https://github.com/apache/commons-compress/pull/57

    COMPRESS-430: Synchronize iteration of synchronized list

    Synchronize the iteration as per Javadocs http://docs.oracle.com/javase/9/docs/api/java/util/Collections.html#synchronizedList%28java.util.List
    
    JIRA ticket https://issues.apache.org/jira/browse/COMPRESS-430

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kinow/commons-compress synchronize-iteration-of-synchronized-list-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-compress/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
    
----
commit c0499042c2778161d6cecd54357adb6ea9595132
Author: Bruno P. Kinoshita <brunodepaulak@yahoo.com.br>
Date:   2017-11-25T09:57:30Z

    COMPRESS-430: Synchronize iteration of synchronized list

----


> Synchronize iteration on synchronized list in ParallelScatterZipCreator
> -----------------------------------------------------------------------
>
>                 Key: COMPRESS-430
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-430
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Archivers
>    Affects Versions: 1.15
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>              Labels: concurrency
>             Fix For: 1.16
>
>
> Following what is defined in the [Collections javadoc|https://docs.oracle.com/javase/9/docs/api/java/util/Collections.html#synchronizedList(java.util.List)],
it might be a good idea to synchronize when iterating the stream list, that is created with
Collections.synchronizedList.
> This work originated after the pull request submitted to VALIDATOR-434, and searching
other components in commons using similar method to create lists but not synchronizing the
iteration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message