commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COLLECTIONS-599) HashEntry array object naming data initialized with double the size during deserialization
Date Mon, 06 Nov 2017 15:56:00 GMT

    [ https://issues.apache.org/jira/browse/COLLECTIONS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240470#comment-16240470
] 

Gary Gregory commented on COLLECTIONS-599:
------------------------------------------

Hi [~mingleizhang],

Please feel free to provide a pull request on GitHub with a unit test.

https://github.com/apache/commons-collections

Are you expecting that such a change would be in the 3.x AND 4.x (master) branches?

Gary

> HashEntry array object naming data initialized with double the size during deserialization
> ------------------------------------------------------------------------------------------
>
>                 Key: COLLECTIONS-599
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-599
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: Collection, Map
>    Affects Versions: 3.1
>            Reporter: Tejas Patel
>            Priority: Critical
>             Fix For: 4.1
>
>
> Common collections 3.1 and 3.2 are used at many places and frameworks including struts2.

> Supose a LinkedMap object it is created and have size greater than zero is serialized.
While deserializing this object , array of HashEntry naming data delacred in AbstractHashedMap
always initialises with a new capacity of double its double of the serialized object. 
> Please see the below API declared in AbstractHashedMap class :
> {code:java}
> protected void checkCapacity()
>   {
>     if (this.size >= this.threshold)
>     {
>       int newCapacity = this.data.length * 2;
>       if (newCapacity <= 1073741824) {
>         ensureCapacity(newCapacity);
>       }
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message