commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMMONSRDF-49) Make AbstractRDFParser serializable
Date Tue, 14 Nov 2017 16:47:00 GMT

    [ https://issues.apache.org/jira/browse/COMMONSRDF-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251700#comment-16251700
] 

ASF GitHub Bot commented on COMMONSRDF-49:
------------------------------------------

Github user ajs6f commented on the issue:

    https://github.com/apache/commons-rdf/pull/43
  
    So the question is whether what is here now is a step forward.
    
    I think it is, and I would want to do what is here whether or not we go onto a builder
factoring. I intentionally did not add the marker interface to the type, and I think it's
okay for the moment (especially as this is in the `experimental` package). I can and will
do a builder refactoring, but I don't want to slow anyone down waiting for that.


> Make AbstractRDFParser serializable
> -----------------------------------
>
>                 Key: COMMONSRDF-49
>                 URL: https://issues.apache.org/jira/browse/COMMONSRDF-49
>             Project: Apache Commons RDF
>          Issue Type: New Feature
>          Components: simple
>    Affects Versions: 0.3.0
>            Reporter: Stian Soiland-Reyes
>            Assignee: Stian Soiland-Reyes
>              Labels: parser
>             Fix For: 0.6.0
>
>
> Raised by [~p_ansell] in [pull request 25|(https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85436754]
> {quote}
> The use of optional here as a field type makes it impossible to serialise. Need to have
the raw values stored in fields if you want to support serialisation in the future, which
should otherwise be possible.
> {quote}
> The suggestion is to avoid {{Optional}} in the private fields of {{AbstractRDFParser}}
so it can be serialized - it can still be {{Optional}} in the accessor methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message