Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 24FDD200D27 for ; Tue, 10 Oct 2017 20:03:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 238C6160BE5; Tue, 10 Oct 2017 18:03:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 743EA160BE0 for ; Tue, 10 Oct 2017 20:03:04 +0200 (CEST) Received: (qmail 59585 invoked by uid 500); 10 Oct 2017 18:03:03 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 59561 invoked by uid 99); 10 Oct 2017 18:03:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Oct 2017 18:03:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 996D4183EC7 for ; Tue, 10 Oct 2017 18:03:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ZhazM7obELhz for ; Tue, 10 Oct 2017 18:03:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BAAFE5FC81 for ; Tue, 10 Oct 2017 18:03:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 319D9E0F44 for ; Tue, 10 Oct 2017 18:03:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7FC622538E for ; Tue, 10 Oct 2017 18:03:00 +0000 (UTC) Date: Tue, 10 Oct 2017 18:03:00 +0000 (UTC) From: "Mark Roberts (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BCEL-296) Incorrect comment in several classes. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 10 Oct 2017 18:03:05 -0000 [ https://issues.apache.org/jira/browse/BCEL-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199103#comment-16199103 ] Mark Roberts commented on BCEL-296: ----------------------------------- ok - will try to set up a PR next week. > Incorrect comment in several classes. > ------------------------------------- > > Key: BCEL-296 > URL: https://issues.apache.org/jira/browse/BCEL-296 > Project: Commons BCEL > Issue Type: Improvement > Reporter: Mark Roberts > Priority: Trivial > > There are 70 odd classes in the generic directory that have empty constructors with the following comment: > * Empty constructor needed for the Class.newInstance() statement in > * Instruction.readInstruction(). Not to be used otherwise. > Class.newInstance() is no longer called, the empty constructors are referenced directly. Perhaps the comment should just read: > * Empty constructor needed Instruction.readInstruction(). > * Not to be used otherwise. -- This message was sent by Atlassian JIRA (v6.4.14#64029)