Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
From: jodastephen <git@git.apache.org>
To: issues@commons.apache.org
Reply-To: issues@commons.apache.org
References: <git-pr-299-commons-lang@git.apache.org>
In-Reply-To: <git-pr-299-commons-lang@git.apache.org>
Subject: [GitHub] commons-lang pull request #299: Add module-info for Java 9
Content-Type: text/plain
Message-Id: <20171027142331.B378CDFAE4@git1-us-west.apache.org>
Date: Fri, 27 Oct 2017 14:23:31 +0000 (UTC)
archived-at: Fri, 27 Oct 2017 14:23:33 -0000

Github user jodastephen commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/299#discussion_r147424665
  
    --- Diff: src/main/java/module-info.java ---
    @@ -0,0 +1,41 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +/**
    + * Apache Commons Lang provides utility classes for the core of Java.
    + */
    +module org.apache.commons.lang3 {
    +
    +    // see AbstractCircuitBreaker
    +    requires static java.desktop;
    --- End diff --
    
    Because this is a massive dependency, and we need to avoid dragging it all in for just a small percentage of users. Using `requires static` is an abuse of the module system, but the best option available. `requires transitive` would be the right solution normally.


---