Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
From: chonton <git@git.apache.org>
To: issues@commons.apache.org
Reply-To: issues@commons.apache.org
References: <git-pr-296-commons-lang@git.apache.org>
In-Reply-To: <git-pr-296-commons-lang@git.apache.org>
Subject: [GitHub] commons-lang pull request #296: LANG-1355: Add FastTimeZone to decrease Time...
Content-Type: text/plain
Message-Id: <20171010144118.586FAF3310@git1-us-west.apache.org>
Date: Tue, 10 Oct 2017 14:41:18 +0000 (UTC)
archived-at: Tue, 10 Oct 2017 14:41:20 -0000

Github user chonton commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/296#discussion_r143748869
  
    --- Diff: src/main/java/org/apache/commons/lang3/time/FastTimeZone.java ---
    @@ -0,0 +1,90 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.commons.lang3.time;
    +
    +import java.util.TimeZone;
    +import java.util.regex.Matcher;
    +import java.util.regex.Pattern;
    +
    +/**
    + * Faster methods to produce custom time zones.
    + *
    + * @since 3.7
    + */
    +public class FastTimeZone {
    +
    +    private static final TimeZone GREENWICH = new GmtTimeZone(false, 0, 0);
    +
    +    /**
    +     * Get the GMT TimeZone.
    +     * @return A TimeZone with a raw offset of zero.
    +     */
    +    public static TimeZone getGmtTimeZone() {
    +        return GREENWICH;
    +    }
    +
    +    /**
    +     * Get a TimeZone, looking first for GMT custom ids, then falling back to Olson ids.
    +     * A GMT custom id has an optional prefix of GMT, followed by sign, hours digit(s), optional
    +     * colon(':'), and optional minutes digits: <em>[GMT] (+|-) Hours [[:] Minutes]</em>
    +     *
    +     * @param id A GMT custom id or Olsen id
    +     * @return A timezone
    +     */
    +    public static TimeZone getTimeZone(String id) {
    +        TimeZone tz = getGmtTimeZone(id);
    +        if (tz != null) {
    +            return tz;
    +        }
    +        return TimeZone.getTimeZone(id);
    +    }
    +
    +    private static final Pattern GMT_PATTERN = Pattern.compile("^(?:(?i)GMT)?([+-])?(\\d\\d?)?(:?(\\d\\d?))?$");
    +
    +    /**
    +     * Get a TimeZone with GMT offsets.  A GMT offset must be either 'Z' or match
    +     * (GMT)? hh?(:?mm?)?, where h and m are digits representing hours and minutes.
    --- End diff --
    
    done


---