Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
From: kinow <git@git.apache.org>
To: issues@commons.apache.org
Reply-To: issues@commons.apache.org
References: <git-pr-296-commons-lang@git.apache.org>
In-Reply-To: <git-pr-296-commons-lang@git.apache.org>
Subject: [GitHub] commons-lang pull request #296: LANG-1355: Add FastTimeZone to decrease Time...
Content-Type: text/plain
Message-Id: <20171010090034.2A0D4E030B@git1-us-west.apache.org>
Date: Tue, 10 Oct 2017 09:00:34 +0000 (UTC)
archived-at: Tue, 10 Oct 2017 09:00:37 -0000

Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/296#discussion_r143663160
  
    --- Diff: src/main/java/org/apache/commons/lang3/time/FastTimeZone.java ---
    @@ -0,0 +1,90 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.commons.lang3.time;
    +
    +import java.util.TimeZone;
    +import java.util.regex.Matcher;
    +import java.util.regex.Pattern;
    +
    +/**
    + * Faster methods to produce custom time zones.
    + *
    + * @since 3.7
    + */
    +public class FastTimeZone {
    --- End diff --
    
    Do we need a private constructor to prevent instantiation of FastTimeZone? It seems to contain only static methods. Not sure if that's the intended design. But noticed it while looking at the cobertura report (which is looking great).


---