commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno P. Kinoshita (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (COLLECTIONS-660) Uncomment test in AbstractMapTest regarding LRUMap equals
Date Wed, 04 Oct 2017 04:41:00 GMT

    [ https://issues.apache.org/jira/browse/COLLECTIONS-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190799#comment-16190799
] 

Bruno P. Kinoshita edited comment on COLLECTIONS-660 at 10/4/17 4:40 AM:
-------------------------------------------------------------------------

Due to the order of the arguments of the assertEquals, we were calling TreeMap#equals, which
would create a normal iterator instead of calling mapIterator().

This would change the modCount in the parent, resulting finally in the concurrent modification
exception.


was (Author: kinow):
Due to the order of the arguments of the assertEquals, we were calling TreeMap#equals, which
would create a normal iterator instead of calling mapIterator().

> Uncomment test in AbstractMapTest regarding LRUMap equals
> ---------------------------------------------------------
>
>                 Key: COLLECTIONS-660
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-660
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: Map
>    Affects Versions: 4.1
>            Reporter: Bruno P. Kinoshita
>            Assignee: Bruno P. Kinoshita
>            Priority: Minor
>             Fix For: 4.2
>
>
> AbstractMapTest has a [commented out|https://github.com/apache/commons-collections/blob/c8bdf60d1d0be609094e14054be0b9af0fb05521/src/test/java/org/apache/commons/collections4/map/AbstractMapTest.java#L1959]
line, with a comment as follows:
> {quote}his fails for LRUMap because confirmed.equals() somehow modifies map, causing
concurrent modification exceptions.{quote}
> While working on another test failing on Windows, I believe I've found the why for that
comment, and how to fix it. Just need to finish debugging another part, and find a good Internet
connection to push the fix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message