commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1355) TimeZone.getTimeZone() in FastDateParser causes resource contention
Date Mon, 09 Oct 2017 02:24:00 GMT

    [ https://issues.apache.org/jira/browse/LANG-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196437#comment-16196437
] 

ASF GitHub Bot commented on LANG-1355:
--------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/296
  
    
    [![Coverage Status](https://coveralls.io/builds/13625524/badge)](https://coveralls.io/builds/13625524)
    
    Coverage decreased (-0.01%) to 95.198% when pulling **7670979033076f354af7e4cf852709d5403ffbd4
on chonton:LANG-1355** into **00feb98f807cf44c993296052726043a90d70b7e on apache:master**.



> TimeZone.getTimeZone() in FastDateParser causes resource contention
> -------------------------------------------------------------------
>
>                 Key: LANG-1355
>                 URL: https://issues.apache.org/jira/browse/LANG-1355
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.time.*
>    Affects Versions: 3.6
>         Environment: Windows
>            Reporter: Keith Boone
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Under heavy load we are seeing contention in FastDateParser.parse() on calls to TimeZone.getTimeZone().
 TimeZone.getTimeZone() is a synchronized static in the Oracle JVM.
> Our proposed solution is to add a class TimeZoneCache containing a single method getTimeZone()
which gets the requested time zone from a ConcurrentMap, and if not present, looks it up via
TimeZone.getTimeZone() and caches it before returning it.
> Then replace calls to TimeZone.getTimeZone() in FastDateParser ( and whereever else)
to calls to TimeZoneCache.getTimeZone().  
> The reason to add a separate class is because it can also be used by other applications
which heavily parse or format or do other things where TimeZone is repeatedly needed.
> Under extreme load we have seen an 50:1 improvement in calls to FastDateParser.parse().
 This saves about a ms/call in our test environment, and reduces contention.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message