commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Thomas (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (DAEMON-324) [home.c:130]: (error) Resource leak: cfgf
Date Fri, 20 Oct 2017 10:24:00 GMT

     [ https://issues.apache.org/jira/browse/DAEMON-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mark Thomas resolved DAEMON-324.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 1.1

Fixed. Thanks for the report.

> [home.c:130]: (error) Resource leak: cfgf
> -----------------------------------------
>
>                 Key: DAEMON-324
>                 URL: https://issues.apache.org/jira/browse/DAEMON-324
>             Project: Commons Daemon
>          Issue Type: Bug
>    Affects Versions: 1.0.15
>            Reporter: David Binderman
>            Priority: Minor
>             Fix For: 1.1
>
>
> $ fgrep cfgf ../BUILD/commons-daemon-1.0.15-src/src/native/unix/native/home.c
>     FILE *cfgf = fopen(data->cfgf, "r");
>     if (cfgf == NULL) {
>         log_debug("Can't open %s\n", data->cfgf);
>     while ((ret = fgets(buf, 1024, cfgf)) != NULL) {
>     char *cfgf = NULL;
> Suggest add call to fclose.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message