commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pascal Schumacher (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (TEXT-74) StrSubstitutor: Ability to turn off substitution in values
Date Fri, 13 Oct 2017 15:26:02 GMT

     [ https://issues.apache.org/jira/browse/TEXT-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Pascal Schumacher resolved TEXT-74.
-----------------------------------
       Resolution: Fixed
         Assignee: Rob Tompkins
    Fix Version/s:     (was: 1.x)
                   1.2

> StrSubstitutor: Ability to turn off substitution in values
> ----------------------------------------------------------
>
>                 Key: TEXT-74
>                 URL: https://issues.apache.org/jira/browse/TEXT-74
>             Project: Commons Text
>          Issue Type: Improvement
>            Reporter: Arend v. Reinersdorff
>            Assignee: Rob Tompkins
>            Priority: Minor
>              Labels: features
>             Fix For: 1.2
>
>
> StrSubstitutor replaces variables in values. And currently there's no way to turn this
off.
> Why turn it off: I want to replace some variables in a simple template. Some of the replacement
values are arbitrary user input.
> At the moment I escape all dollar signs in the replacement values with "$$". This is
annoying. Especially as I use one template with variables as a value for another variable.
Here I have to escape twice.
> Here's some example code. At the moment it prints:
> {code}
> Hello Hamburg from Hamburg
> {code}
> The commented line is my suggestion for this feature. If it works, it should print:
> {code}
> Hello ${city} from Hamburg
> {code}
> {code}
> // untrusted user input
> String userInputName = "${city}";
> String userInputCity = "Hamburg";
> Map<String, String> valueMap = new HashMap<>();
> valueMap.put("name", userInputName);
> valueMap.put("city", userInputCity);
> String source = "Hello ${name} from ${city}";
> StrSubstitutor strSubstitutor = new StrSubstitutor(valueMap);
> // strSubstitutor.setEnableSubstitutionInValues(false);
> System.out.println(strSubstitutor.replace(source));
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message