commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From britter <...@git.apache.org>
Subject [GitHub] commons-lang pull request #301: Clean up EventUtilsTest
Date Sat, 21 Oct 2017 15:35:52 GMT
Github user britter commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/301#discussion_r146108051
  
    --- Diff: src/test/java/org/apache/commons/lang3/event/EventUtilsTest.java ---
    @@ -135,9 +129,9 @@ public void testBindFilteredEventsToMethod() {
             final EventCounter counter = new EventCounter();
             EventUtils.bindEventsToMethod(counter, "eventOccurred", src, MultipleEventListener.class,
"event1");
             assertEquals(0, counter.getCount());
    -        src.listeners.fire().event1(new PropertyChangeEvent(new Date(), "Day", Integer.valueOf(0),
Integer.valueOf(1)));
    +        src.listeners.fire().event1(new PropertyChangeEvent(new Date(), "Day", 0, 1));
    --- End diff --
    
    We prefer explicit boxing of primitve values.


---

Mime
View raw message