commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PascalSchumacher <...@git.apache.org>
Subject [GitHub] commons-lang pull request #296: LANG-1355: Add FastTimeZone to decrease Time...
Date Tue, 10 Oct 2017 16:26:29 GMT
Github user PascalSchumacher commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/296#discussion_r143781416
  
    --- Diff: src/main/java/org/apache/commons/lang3/time/FastTimeZone.java ---
    @@ -39,10 +43,11 @@ public static TimeZone getGmtTimeZone() {
     
         /**
          * Get a TimeZone, looking first for GMT custom ids, then falling back to Olson ids.
    -     * A GMT custom id has an optional prefix of GMT, followed by sign, hours digit(s),
optional
    -     * colon(':'), and optional minutes digits: <em>[GMT] (+|-) Hours [[:] Minutes]</em>
    +     * A GMT custom id can be 'Z', or 'UTC', or has an optional prefix of GMT,
    +     * followed by sign, hours digit(s), optional colon(':'), and optional minutes digits.
    +     * i.e. <em>[GMT] (+|-) Hours [[:] Minutes]</em>
          *
    -     * @param id A GMT custom id or Olsen id
    +     * @param id A GMT custom id (or Olson id
    --- End diff --
    
    Nitpick: either a superfluous `(` or a missing `)`


---

Mime
View raw message