commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PascalSchumacher <...@git.apache.org>
Subject [GitHub] commons-lang pull request #297: Add a rule of Locale.ENGLISH to String.toUpp...
Date Mon, 09 Oct 2017 19:23:54 GMT
Github user PascalSchumacher commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/297#discussion_r143555903
  
    --- Diff: src/main/java/org/apache/commons/lang3/time/FormatCache.java ---
    @@ -240,7 +240,7 @@ public boolean equals(final Object obj) {
                 // Eliminate the usual boilerplate because
                 // this inner static class is only used in a generic ConcurrentHashMap
                 // which will not compare against other Object types
    -            return Arrays.equals(keys, ((MultipartKey)obj).keys);
    +            return obj instanceof MultipartKey && Arrays.equals(keys, ((MultipartKey)obj).keys);
    --- End diff --
    
    Please do not include unrelated changes in a single pull request. Thanks!


---

Mime
View raw message