commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LOGGING-163) BufferedReader is not closed properly
Date Tue, 26 Sep 2017 15:00:09 GMT

     [ https://issues.apache.org/jira/browse/LOGGING-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Benedikt Ritter updated LOGGING-163:
------------------------------------
    Fix Version/s:     (was: Nightly Builds)
                   1.2.1

> BufferedReader is not closed properly
> -------------------------------------
>
>                 Key: LOGGING-163
>                 URL: https://issues.apache.org/jira/browse/LOGGING-163
>             Project: Commons Logging
>          Issue Type: Bug
>    Affects Versions: 1.1.1, 1.2
>            Reporter: Kaloyan Spiridonov
>            Assignee: Gary Gregory
>             Fix For: 1.2.1
>
>
> In LogFactory class at line 552 there is BufferedReader that is not closed properly.
For example if rd.readLine(); throw an exception then the Reader will remain open.
> {code}
>  BufferedReader rd;
> try {
>     rd = new BufferedReader(new InputStreamReader(is, "UTF-8"));
>  } catch (java.io.UnsupportedEncodingException e) {
>      rd = new BufferedReader(new InputStreamReader(is));
> }
> String factoryClassName = rd.readLine();
> rd.close();
> {code}
> In SimpleLog class at line 163 there is InputStream that is not closed properly. 
> {code}
>         InputStream in = getResourceAsStream("simplelog.properties");
>         if(null != in) {
>             try {
>                 simpleLogProps.load(in);
>                 in.close();
>             } catch(java.io.IOException e) {
>                 // ignored
>             }
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message