Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3CB33200CE7 for ; Thu, 3 Aug 2017 04:36:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 39619160F5C; Thu, 3 Aug 2017 02:36:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7FC98160D87 for ; Thu, 3 Aug 2017 04:36:04 +0200 (CEST) Received: (qmail 17890 invoked by uid 500); 3 Aug 2017 02:36:03 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 17879 invoked by uid 99); 3 Aug 2017 02:36:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Aug 2017 02:36:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 29C3AC05D5 for ; Thu, 3 Aug 2017 02:36:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id QU6fa-5VkUrb for ; Thu, 3 Aug 2017 02:36:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 46F8D5FD55 for ; Thu, 3 Aug 2017 02:36:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AA0D4E012F for ; Thu, 3 Aug 2017 02:36:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 213B72464D for ; Thu, 3 Aug 2017 02:36:00 +0000 (UTC) Date: Thu, 3 Aug 2017 02:36:00 +0000 (UTC) From: "David Nickerson (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MATH-1427) Unreachable statements in Complex.abs() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 03 Aug 2017 02:36:05 -0000 [ https://issues.apache.org/jira/browse/MATH-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Nickerson updated MATH-1427: ---------------------------------- Attachment: complex_abs.patch > Unreachable statements in Complex.abs() > --------------------------------------- > > Key: MATH-1427 > URL: https://issues.apache.org/jira/browse/MATH-1427 > Project: Commons Math > Issue Type: Bug > Affects Versions: 3.6.1 > Reporter: David Nickerson > Priority: Minor > Labels: easyfix, newbie, patch > Attachments: complex_abs.patch > > > This return statement in Complex.abs() is unreachable: > {code:java} > if (FastMath.abs(real) < FastMath.abs(imaginary)) { > if (imaginary == 0.0) { > return FastMath.abs(real); > } > {code} > If imaginary == 0, then there's no way that the preceding condition would be true. There are two similar inner 'if' statements that were accidentally switched. Returned values are still correct, but performance suffers. > The attached patch switches these back. Note that we're still protected from dividing by zero. -- This message was sent by Atlassian JIRA (v6.4.14#64029)