Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 3 Aug 2017 02:35:00 +0000 (UTC)
From: "David Nickerson (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13092055.1501727647000.80392.1501727700031@Atlassian.JIRA>
In-Reply-To: <JIRA.13092055.1501727647000@Atlassian.JIRA>
References: <JIRA.13092055.1501727647000@Atlassian.JIRA> <JIRA.13092055.1501727647488@jira-lw-us.apache.org>
Subject: [jira] [Created] (MATH-1427) Unreachable statements in
 Complex.abs()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 03 Aug 2017 02:35:06 -0000

David Nickerson created MATH-1427:
-------------------------------------

             Summary: Unreachable statements in Complex.abs()
                 Key: MATH-1427
                 URL: https://issues.apache.org/jira/browse/MATH-1427
             Project: Commons Math
          Issue Type: Bug
    Affects Versions: 3.6.1
            Reporter: David Nickerson
            Priority: Minor


This return statement in Complex.abs() is unreachable:

{code:java}
if (FastMath.abs(real) < FastMath.abs(imaginary)) {
  if (imaginary == 0.0) {
    return FastMath.abs(real);
  }
{code}

If imaginary == 0, then there's no way that the preceding condition would be true. There are two similar inner 'if' statements that were accidentally switched. Returned values are still correct, but performance suffers.

The attached patch switches these back. Note that we're still protected from dividing by zero.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)