Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 64F1E200CDA for ; Fri, 4 Aug 2017 15:56:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6375E16CE74; Fri, 4 Aug 2017 13:56:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A2FFB169D48 for ; Fri, 4 Aug 2017 15:56:09 +0200 (CEST) Received: (qmail 23849 invoked by uid 500); 4 Aug 2017 13:56:07 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 23653 invoked by uid 99); 4 Aug 2017 13:56:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Aug 2017 13:56:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 151FE18080C for ; Fri, 4 Aug 2017 13:56:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -98.702 X-Spam-Level: X-Spam-Status: No, score=-98.702 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id FeW-a5LWIMAq for ; Fri, 4 Aug 2017 13:56:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 107D05FD1B for ; Fri, 4 Aug 2017 13:56:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 86EC9E0D6A for ; Fri, 4 Aug 2017 13:56:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id ACE9324DE8 for ; Fri, 4 Aug 2017 13:56:02 +0000 (UTC) Date: Fri, 4 Aug 2017 13:56:02 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (NET-641) SubnetUtils.SubnetInfo.isInRange("0.0.0.0") returns true for CIDR/31, 32 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 04 Aug 2017 13:56:10 -0000 [ https://issues.apache.org/jira/browse/NET-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114393#comment-16114393 ] Sebb commented on NET-641: -------------------------- isInRange ignores isInclusiveHostCount in order to do what the Javadoc says it will do. If there is a use-case for a new method that takes this into account then please raise an enhancement request. Ideally with test cases. > SubnetUtils.SubnetInfo.isInRange("0.0.0.0") returns true for CIDR/31, 32 > ------------------------------------------------------------------------ > > Key: NET-641 > URL: https://issues.apache.org/jira/browse/NET-641 > Project: Commons Net > Issue Type: Bug > Affects Versions: 3.6 > Environment: Windows; JDK8; common-net 3.6 > Reporter: pin_ptr > Priority: Minor > Fix For: 3.7 > > > Code: > import org.apache.commons.net.util.SubnetUtils; > public class A { > public static void main(String[] args) { > System.out.println(new SubnetUtils("192.168.1.0/30").getInfo().isInRange("0.0.0.0")); > System.out.println(new SubnetUtils("192.168.1.0/31").getInfo().isInRange("0.0.0.0")); > System.out.println(new SubnetUtils("192.168.1.0/32").getInfo().isInRange("0.0.0.0")); > } > } > Result: > false > true > true > Expected: > false > false > false -- This message was sent by Atlassian JIRA (v6.4.14#64029)