commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1350) ConstructorUtils.invokeConstructor(Class, Object...) regression
Date Sun, 20 Aug 2017 18:27:02 GMT

    [ https://issues.apache.org/jira/browse/LANG-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134520#comment-16134520
] 

ASF GitHub Bot commented on LANG-1350:
--------------------------------------

GitHub user bjkail opened a pull request:

    https://github.com/apache/commons-lang/pull/283

    LANG-1350: Fix varargs array invokeConstructor

    If ConstructorUtils.invokeConstructor(Class, Object...) is invoked with an array of arguments
whose classes do not match a constructor exactly (for example, a subclass is used) and an
array is used for a varargs parameter, then the array is not matched to the varargs parameter
type.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjkail/commons-lang LANG-1350

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #283
    
----
commit a54613f4c8774c34a9942b3ffe93d803fcc452cd
Author: Brett Kail <bjkail@gmail.com>
Date:   2017-08-20T18:25:41Z

    LANG-1350: Fix varargs array invokeConstructor
    
    If ConstructorUtils.invokeConstructor(Class, Object...) is invoked with
    an array of arguments whose classes do not match a constructor exactly
    (for example, a subclass is used) and an array is used for a varargs
    parameter, then the array is not matched to the varargs parameter type.

----


> ConstructorUtils.invokeConstructor(Class, Object...) regression
> ---------------------------------------------------------------
>
>                 Key: LANG-1350
>                 URL: https://issues.apache.org/jira/browse/LANG-1350
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.reflect.*
>    Affects Versions: 3.5, 3.6
>            Reporter: Brett Kail
>
> As of LANG-1115, the following test program no longer works:
> {noformat}
> public class ConstructorUtilsTest {
> 	@Test
> 	public void test() throws Exception {
> 		ConstructorUtils.invokeConstructor(TestCtor.class, new A() {}, new B[0]);
> 	}
> 	public static class TestCtor {
> 		public TestCtor(A a, B... b) {}
> 	}
> 	public static class A {}
> 	public static class B {}
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message